Skip to content

Commit

Permalink
Respond to review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Steve Peters <[email protected]>
  • Loading branch information
scpeters committed Aug 13, 2020
1 parent 15fee5d commit 57230f5
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions pose_frame_semantics/proposal.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Eric Cousineau `<[email protected]>`
* **SDFormat Version**: 1.7
* **`libsdformat` Version**: 9.0 (initial support), 9.3 (nested models)

All sections affected by ammendments are explicitly denoted as being added or
All sections affected by amendments are explicitly denoted as being added or
modified.

These are added as amendments given that the current proposal has not yet been
Expand Down Expand Up @@ -392,15 +392,19 @@ that disallows name conflicts like this.
In SDFormat 1.4, the only objects referenced by name are the links
named in `//joint/parent` and `//joint/child`, and the names are always
scoped to the current model.

In SDFormat 1.5, the `::` delimiter is used to indicate that the target
link is within a nested model, but the scope is still limited to
objects contained in the current model.
The `::` syntax for referencing across model boundaries is not supported
by SDFormat 1.7.

In SDFormat 1.7, the `::` syntax for referencing across model boundaries is not supported.
With the addition of `//world/frame` and `//world/model/pose/@relative_to`,
it is necessary to consider the world scope separately from each
model's scope to avoid name conflicts and ensure encapsulation.

In SDFormat 1.8, the `::` syntax for referencing across model boundaries will be
formalized and supported.

##### 3.1.1 Alternatives considered

One alternative was to not use any scoping at all, such that any frame could
Expand Down Expand Up @@ -623,7 +627,6 @@ and thus indirectly attached to the canonical link.
<frame name="F0" attached_to=""/> <!-- VALID: Indirectly attached_to canonical link L via the model frame. -->
<frame name="F1" attached_to="M"/> <!-- VALID: Indirectly attached_to nested model M. -->
<frame name="F2" attached_to="F1"/> <!-- VALID: Indirectly attached_to nested model M via frame F1. -->
<frame name="F3" attached_to="A"/> <!-- INVALID: no sibling frame named A. -->
</model>
~~~

Expand Down Expand Up @@ -771,6 +774,7 @@ the implicit world frame.

~~~
<model name="nested_model_pose_relative_to">
<frame name="M"/> <!-- Explicit frame M identical to implicit model frame __model__. -->
<link name="L"/>
<model name="M1">
<pose>{X_MM1}</pose> <!-- Pose relative_to implicit model frame (M) by default. -->
Expand Down

0 comments on commit 57230f5

Please sign in to comment.