Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests and warnings for 3 -> 6 forward port #819

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jan 30, 2023

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

Changes to get CI to be green again

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #819 (33b0220) into nkoenig/3-to-6-20230120 (87f6bf7) will decrease coverage by 3.80%.
The diff coverage is 61.70%.

@@                     Coverage Diff                     @@
##           nkoenig/3-to-6-20230120     #819      +/-   ##
===========================================================
- Coverage                    83.36%   79.57%   -3.80%     
===========================================================
  Files                          100      146      +46     
  Lines                         7815    13434    +5619     
===========================================================
+ Hits                          6515    10690    +4175     
- Misses                        1300     2744    +1444     
Impacted Files Coverage Δ
include/gz/rendering/ArrowVisual.hh 100.00% <ø> (ø)
include/gz/rendering/AxisVisual.hh 0.00% <ø> (-100.00%) ⬇️
include/gz/rendering/Camera.hh 100.00% <ø> (ø)
include/gz/rendering/Geometry.hh 100.00% <ø> (ø)
include/gz/rendering/GpuRays.hh 100.00% <ø> (+100.00%) ⬆️
include/gz/rendering/JointVisual.hh 0.00% <0.00%> (ø)
include/gz/rendering/Light.hh 100.00% <ø> (ø)
include/gz/rendering/Material.hh 100.00% <ø> (ø)
include/gz/rendering/Mesh.hh 100.00% <ø> (ø)
include/gz/rendering/Node.hh 100.00% <ø> (ø)
... and 106 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nkoenig nkoenig merged commit 417c7f7 into nkoenig/3-to-6-20230120 Jan 31, 2023
@nkoenig nkoenig deleted the iche033/3-to-6-fixes branch January 31, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants