Forward port 3 to 6, Jan 29 2023 #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
…oller, PixelFormat and ShadersParams (#748) Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
* Migrate headers Signed-off-by: methylDragon <[email protected]> * Add redirection headers Signed-off-by: methylDragon <[email protected]> * Migrate include statements Signed-off-by: methylDragon <[email protected]> * Leave ignition as primary in headers to fix ABI Signed-off-by: methylDragon <[email protected]> * Fix test Signed-off-by: Nate Koenig <[email protected]> * Removed some gazeb classic code Signed-off-by: Nate Koenig <[email protected]> * Revert changes Signed-off-by: Nate Koenig <[email protected]> * revert to gazebo in gazebo scene viewer Signed-off-by: Ian Chen <[email protected]> * fix build errors Signed-off-by: Ian Chen <[email protected]> Signed-off-by: methylDragon <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
|
Did a first pass review. Started fixing warnings and tests in #819 |
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #815 +/- ##
==================================================
+ Coverage 77.83% 79.65% +1.81%
==================================================
Files 146 146
Lines 13432 13437 +5
==================================================
+ Hits 10455 10703 +248
+ Misses 2977 2734 -243
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
iche033
reviewed
Feb 1, 2023
iche033
approved these changes
Feb 2, 2023
ahcorde
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port ign-rendering3 to ign-rendering6
Branch comparison: https://github.com/gazebosim//compare/<TO_BRANCH>...<FROM_BRANCH>
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)