Provide a Virtual Method Anchor for Classes in Headers #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcarroll
changed the title
mjcarroll
force-pushed
the
mjcarroll/anchor_virtual
branch
from
aa05561 to
6d3bbe1
Compare
ahcorde
previously requested changes
Aug 17, 2022
There was a problem hiding this comment.
/github/workspace/include/gz/rendering/ArrowVisual.hh:35: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
/github/workspace/include/gz/rendering/BoundingBox.hh:53: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
mjcarroll
force-pushed
the
mjcarroll/anchor_virtual
branch
from
0139270 to
3802725
Compare
Codecov Report
@@ Coverage Diff @@
## gz-rendering7 #708 +/- ##
=================================================
- Coverage 74.18% 74.14% -0.05%
=================================================
Files 159 164 +5
Lines 14370 14351 -19
=================================================
- Hits 10661 10641 -20
- Misses 3709 3710 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@osrf-jenkins retest this please |
iche033
reviewed
Aug 24, 2022
Signed-off-by: Michael Carroll <[email protected]>
iche033
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Based on #702 (comment)
Summary
We have some classes defined in headers that need to have at least one virtual method implemented in a
ccfile.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.