Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure one texture per selection buffer per camera. #665

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jul 8, 2022

🦟 Bug fix

Fixes #664

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@hidmic hidmic requested a review from iche033 as a code owner July 8, 2022 20:10
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 8, 2022
@hidmic
Copy link
Contributor Author

hidmic commented Jul 8, 2022

@iche033 while this patch certainly fixes the issue I had over at https://github.com/osrf/lrauv, it's unclear to me how to write a regression test that can trigger it. Adding another camera and ray query pair to RayQuery_TEST.cc won't do.

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #665 (11ca3bf) into main (67ee5db) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   53.59%   53.59%           
=======================================
  Files         214      214           
  Lines       21420    21423    +3     
=======================================
+ Hits        11479    11481    +2     
- Misses       9941     9942    +1     
Impacted Files Coverage Δ
ogre2/src/Ogre2SelectionBuffer.cc 93.06% <100.00%> (+0.08%) ⬆️
include/gz/rendering/base/BaseGaussianNoisePass.hh 96.66% <0.00%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67ee5db...11ca3bf. Read the comment docs.

@chapulina chapulina added the MBARI-LRAUV Sponsored by MBARI-LRAUV project: https://github.com/osrf/lrauv label Jul 11, 2022
@iche033 iche033 mentioned this pull request Jul 11, 2022
8 tasks
@iche033
Copy link
Contributor

iche033 commented Jul 11, 2022

@hidmic can you give #666 a try and see if it fixes your use case in lrauv? That' PR tries to see if we can reuse the same render texture. I also updated the RayQuery unit test to trigger the bug.

* test mulitple ray queries

Signed-off-by: Ian Chen <[email protected]>

* style

Signed-off-by: Ian Chen <[email protected]>

* make string const, style, doc

Signed-off-by: Ian Chen <[email protected]>
@hidmic
Copy link
Contributor Author

hidmic commented Jul 13, 2022

Thank you @iche033 !

@hidmic hidmic merged commit 8d7e008 into main Jul 13, 2022
@hidmic hidmic deleted the hidmic/one-selection-buffer-per-camera branch July 13, 2022 19:03
iche033 pushed a commit that referenced this pull request Jul 27, 2022
ahcorde pushed a commit that referenced this pull request Jul 28, 2022
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>

Co-authored-by: Michel Hidalgo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden MBARI-LRAUV Sponsored by MBARI-LRAUV project: https://github.com/osrf/lrauv
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants