-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure one texture per selection buffer per camera. #665
Conversation
Signed-off-by: Michel Hidalgo <[email protected]>
@iche033 while this patch certainly fixes the issue I had over at https://github.com/osrf/lrauv, it's unclear to me how to write a regression test that can trigger it. Adding another camera and ray query pair to |
Codecov Report
@@ Coverage Diff @@
## main #665 +/- ##
=======================================
Coverage 53.59% 53.59%
=======================================
Files 214 214
Lines 21420 21423 +3
=======================================
+ Hits 11479 11481 +2
- Misses 9941 9942 +1
Continue to review full report at Codecov.
|
* test mulitple ray queries Signed-off-by: Ian Chen <[email protected]> * style Signed-off-by: Ian Chen <[email protected]> * make string const, style, doc Signed-off-by: Ian Chen <[email protected]>
Thank you @iche033 ! |
Signed-off-by: Ian Chen <[email protected]> Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Ian Chen <[email protected]> Signed-off-by: Michel Hidalgo <[email protected]> Co-authored-by: Michel Hidalgo <[email protected]>
🦟 Bug fix
Fixes #664
Summary
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.