Expose GraphicsAPI #565
Merged
Expose GraphicsAPI #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matias N. Goldberg <[email protected]>
Signed-off-by: Matias N. Goldberg <[email protected]>
7 tasks
Codecov Report
@@ Coverage Diff @@
## main #565 +/- ##
==========================================
- Coverage 53.14% 53.12% -0.02%
==========================================
Files 213 214 +1
Lines 21219 21225 +6
==========================================
Hits 11276 11276
- Misses 9943 9949 +6
Continue to review full report at Codecov.
|
iche033
reviewed
Feb 22, 2022
Signed-off-by: Matias N. Goldberg <[email protected]>
iche033
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
There's no ticket assigned to this issue.
Summary
The current GraphicsAPI is only available at Ogre2RenderEngine level, which is problematic when we want to be aware of it for multiple means.
ign-gui needs this information so it can decide on how to interface the API with Qt.
In some cases initialization may need additional steps if different APIs are used; so this info is needed.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.