Don't assume CMAKE_INSTALL_*DIR
variables are relative
#305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
The
CMAKE_INSTALL_*DIR
variables are allowed to be absolute paths, so they cannot be simply appended toCMAKE_INSTALL_PREFIX
. When an absolute path is needed,CMAKE_INSTALL_FULL_*DIR
must be used. See here for more information: https://github.com/jtojnar/cmake-snips#assuming-cmake_install_dir-is-relative-pathAdditionally, pkgconfig files should use
${prefix}
relative paths ifCMAKE_INSTALL_*DIR
are relative, but otherwise use absolute paths. This is handled by the customjoin_paths()
function.Note that CMake 3.20 provides
cmake_path(APPEND)
which implements the same functionality asjoin_paths()
, but this CMake version is not available in all supported distros yet (notably Ubuntu older than 22.04).Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.