Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable playback.ReplayStep for windows #517

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Crola1702
Copy link
Contributor

🦟 Bug fix

Disables #195

This tests has been failing flaky for a really long time. As discussed in Gazebo PMC meeting, this test will be disabled.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Crola1702 Crola1702 requested review from azeey and Blast545 August 8, 2024 20:37
@Crola1702 Crola1702 self-assigned this Aug 8, 2024
@Crola1702 Crola1702 requested a review from caguero as a code owner August 8, 2024 20:37
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 8, 2024
@Crola1702 Crola1702 merged commit 42b119e into ign-transport8 Aug 8, 2024
10 checks passed
@Crola1702 Crola1702 deleted the Crola1702/disable-windows-test branch August 8, 2024 23:19
@Crola1702 Crola1702 mentioned this pull request Aug 8, 2024
Crola1702 added a commit that referenced this pull request Aug 8, 2024
Crola1702 added a commit that referenced this pull request Aug 21, 2024
azeey added a commit that referenced this pull request Aug 23, 2024
11 ➡️ 12 - Disable playback.ReplayStep for windows (#517)
Crola1702 added a commit that referenced this pull request Aug 23, 2024
Crola1702 added a commit that referenced this pull request Aug 26, 2024
12 ➡️ 13 - Disable playback.ReplayStep for windows (#517)
claraberendsen pushed a commit to claraberendsen/gz-transport that referenced this pull request Oct 1, 2024
claraberendsen pushed a commit to claraberendsen/gz-transport that referenced this pull request Oct 1, 2024
azeey pushed a commit that referenced this pull request Oct 1, 2024
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: claraberendsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants