Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install ign command #56

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Install ign command #56

merged 1 commit into from
Jun 28, 2021

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel [email protected]

🦟 Bug fix

Fixes gazebosim/gz-sim#886

Summary

It was removed by mistake on #55

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina
Install command
674d239 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from j-rivero June 26, 2021 04:13
@chapulina chapulina requested a review from caguero as a code owner June 26, 2021 04:13
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Jun 26, 2021
@chapulina chapulina mentioned this pull request Jun 26, 2021
Closed
@traversaro traversaro mentioned this pull request Jun 26, 2021
Merged
8 tasks
francocipollone
francocipollone approved these changes Jun 28, 2021
View reviewed changes
Copy link

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjcarroll mjcarroll merged commit 6741c4f into ign-tools1 Jun 28, 2021
@mjcarroll mjcarroll deleted the chapulina/ign branch June 28, 2021 13:53
@j-rivero
Copy link
Contributor

ouch, thanks @chapulina !

scpeters added a commit that referenced this pull request Sep 28, 2021
@scpeters
merge changelog entries
6627515 
PR #56 fixed a bug in #55 so merge their entries

Signed-off-by: Steve Peters <[email protected]>
caguero pushed a commit that referenced this pull request Sep 28, 2021
@chapulina @scpeters
🎈 1.3.0 (#62)
793bf18 
* 🎈 1.3.0

Signed-off-by: Louise Poubel <[email protected]>

* merge changelog entries

PR #56 fixed a bug in #55 so merge their entries

Signed-off-by: Steve Peters <[email protected]>

Co-authored-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francocipollone francocipollone francocipollone approved these changes

@traversaro traversaro traversaro approved these changes

@mjcarroll mjcarroll mjcarroll approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

command line tool not available ( Ignition Fortress)
5 participants
@chapulina @j-rivero @mjcarroll @traversaro @francocipollone