Added VisualizationCapabilities plugin #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #988 +/- ##
==========================================
- Coverage 63.28% 63.23% -0.05%
==========================================
Files 238 238
Lines 19423 19423
==========================================
- Hits 12292 12283 -9
- Misses 7131 7140 +9
Continue to review full report at Codecov.
|
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
chapulina
reviewed
Aug 25, 2021
There was a problem hiding this comment.
I tried to view collisions for a double pendulum and it crashed with:
[GUI] [Err] [VisualizationCapabilities.cc:1005] Entity with Id: [12] already exists in the scene
backtrace
/home/chapulina/dev_bionic/ws_fortress/install/lib/ign-gazebo-6/plugins/gui/libVisualizationCapabilities.so(_ZN8ignition6gazebo32Visualizati
onCapabilitiesPrivate8OnRenderEv+0x111c) [0x7fdd46038c4c] /usr/include/c++/8/bits/shared_ptr_base.h:1019
/home/chapulina/dev_bionic/ws_fortress/install/lib/ign-gazebo-6/plugins/gui/libVisualizationCapabilities.so(_ZN8ignition6gazebo25Visualizati
onCapabilities11eventFilterEP7QObjectP6QEvent+0x32) [0x7fdd46039262] /home/chapulina/dev_bionic/ws_fortress/src/ign-gazebo/src/gui/plugins/v
isualization_capabilities/VisualizationCapabilities.cc:1973
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5(_ZN23QCoreApplicationPrivate29sendThroughObjectEventFiltersEP7QObjectP6QEvent+0x7c) [0x7fdd85bd45b
c]
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(_ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent+0x75) [0x7fdd84a2c815]
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(_ZN12QApplication6notifyEP7QObjectP6QEvent+0x2a4) [0x7fdd84a34104]
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5(_ZN16QCoreApplication15notifyInternal2EP7QObjectP6QEvent+0x118) [0x7fdd85bd48d8]
/home/chapulina/dev_bionic/ws_fortress/install/lib/ign-gui-6/plugins/libMinimalScene.so(_ZN8ignition3gui7plugins11IgnRenderer6RenderEv+0x140
) [0x7fdd683a8500] /usr/include/x86_64-linux-gnu/qt5/QtCore/qcoreapplication.h:233
/home/chapulina/dev_bionic/ws_fortress/install/lib/ign-gui-6/plugins/libMinimalScene.so(_ZN8ignition3gui7plugins12RenderThread10RenderNextEv
+0x48) [0x7fdd683a8e68] /home/chapulina/dev_bionic/ws_fortress/src/ign-gui/src/plugins/minimal_scene/MinimalScene.cc:419
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5(_ZN7QObject5eventEP6QEvent+0xe2) [0x7fdd85c040c2]
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(_ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent+0x9c) [0x7fdd84a2c83c]
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(_ZN12QApplication6notifyEP7QObjectP6QEvent+0x2a4) [0x7fdd84a34104]
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5(_ZN16QCoreApplication15notifyInternal2EP7QObjectP6QEvent+0x118) [0x7fdd85bd48d8]
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5(_ZN23QCoreApplicationPrivate16sendPostedEventsEP7QObjectiP11QThreadData+0x1ed) [0x7fdd85bd704d]
src/gui/plugins/visualization_capabilities/VisualizationCapabilities.hh
Outdated
Show resolved
Hide resolved
src/gui/plugins/visualization_capabilities/VisualizationCapabilities.hh
Outdated
Show resolved
Hide resolved
Signed-off-by: ahcorde <[email protected]>
This was referenced Sep 8, 2021
Fixed here 72cba8f |
chapulina
suggested changes
Sep 13, 2021
There was a problem hiding this comment.
It's working for me! I think we just need to add joint visualization (#961)
CC @atharva-18
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
|
cpplint is failing but it fixed here #1025 |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
approved these changes
Sep 14, 2021
src/gui/plugins/visualization_capabilities/VisualizationCapabilities.cc
Outdated
Show resolved
Hide resolved
|
CI is broken for other reasons, let's get this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #
Summary
This plugin add visualization capabilities such us: wireframes, inertia, COM and transparent to the minimalScene approach.
Note: right click in the scene3D is not working (yet).
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge