Add ModelSDF serializer #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Agüero <[email protected]>
azeey
reviewed
Jun 7, 2021
Signed-off-by: Carlos Agüero <[email protected]>
azeey
reviewed
Jun 18, 2021
|
I'm considering closing this PR in favor of pull request #881. That way all the changes needed for "Scaling" will be contained in the |
The changes here are pretty self-contained and independent of scaling, so I think it's ok to get it into |
Signed-off-by: Carlos Agüero <[email protected]>
jennuine
reviewed
Aug 2, 2021
| std::string sdf(std::istreambuf_iterator<char>(_in), {}); | ||
|
|
||
| sdf::Errors errors = root.LoadSdfString(sdf); | ||
| if (!errors.empty()) |
There was a problem hiding this comment.
Should this check !root.Element()->HasElement("model") instead? #881 (comment)
Signed-off-by: Carlos Agüero <[email protected]>
azeey
approved these changes
Aug 12, 2021
WilliamLewww
pushed a commit
to WilliamLewww/ign-gazebo
that referenced
this pull request
Dec 7, 2021
* Add ModelSDF serializer. Signed-off-by: Carlos Agüero <[email protected]> Signed-off-by: William Lew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Adds a serializer to the
ModelSDFcomponent.Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge