-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thermal sensor system for configuring thermal camera properties #614
Merged
Merged
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
cb6e37a
add thermal sensor system
iche033 b3dbd32
fix segfaul remove comment
iche033 6b10f2a
Merge branch 'ign-gazebo4' into thermal_sensor_system
iche033 ee13143
feedback and add test
iche033 62eccaa
Merge branch 'thermal_sensor_system' of github.com:ignitionrobotics/i…
iche033 03cfb99
update example world image display topic
iche033 1e538c9
add test for checking invalid properties
iche033 1d5ebc7
Merge branch 'ign-gazebo4' into thermal_sensor_system
iche033 bd203a2
white space
iche033 ea8b55d
typo
iche033 f377905
read thermal data from spawned visuals
iche033 3935064
split test
iche033 2413f4d
add test src file
iche033 ba08f99
use common::joinPaths() in tests
adlarkin c830f45
better msg
iche033 d56d772
fixing CI
iche033 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, should we modify the other thermal camera's topic to be
thermal_camera/image
? Right now, the 8 bit camera has topics/thermal_camera_8bit/image
and/thermal_camera_8bit/camera_info
, but the original thermal camera has topics/thermal_camera
and/camera_info
, which might confuse users. I think it would be good to make the original thermal camera use the topics/thermal_camera/image
and/thermal_camera/camera_info
so that there's consistency between the two thermal cameras.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't touch the existing topics in case there are users out there relying on these topics in this world.
How about we change it in Edifice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine 👍 I'll just make sure I explicitly point out which topics are associated with which camera in the tutorial