Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick acoustic comms to gz-sim7 #1704

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

adityapande-1995
Copy link
Contributor

@adityapande-1995 adityapande-1995 commented Sep 14, 2022

This PR cherry picks acoustic comms plugin and the example world file, already merged here in mbari/gz-sim7 :

Keeping this a draft until gz-sim7 branch is open for PRs.

* Added acoustic comms plugin

Signed-off-by: Aditya <[email protected]>
* Added acoustic comms example
Signed-off-by: Aditya <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 14, 2022
@adityapande-1995 adityapande-1995 marked this pull request as draft September 14, 2022 01:14
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1704 (5c307e0) into gz-sim7 (ff1c82b) will increase coverage by 0.06%.
The diff coverage is 93.22%.

@@             Coverage Diff             @@
##           gz-sim7    #1704      +/-   ##
===========================================
+ Coverage    63.90%   63.97%   +0.06%     
===========================================
  Files          334      335       +1     
  Lines        26344    26403      +59     
===========================================
+ Hits         16836    16891      +55     
- Misses        9508     9512       +4     
Impacted Files Coverage Δ
src/systems/acoustic_comms/AcousticComms.cc 93.22% <93.22%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adityapande-1995 adityapande-1995 changed the title Aditya/cherry pick acoustic comms Cherry pick acoustic comms to gz-sim7 Sep 14, 2022
@adityapande-1995 adityapande-1995 marked this pull request as ready for review October 3, 2022 17:30
@adityapande-1995 adityapande-1995 merged commit 1068296 into gz-sim7 Oct 7, 2022
@adityapande-1995 adityapande-1995 deleted the aditya/cherry-pick-acoustic-comms branch October 7, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants