Model Editor: Add Joints to model

[mjcarroll]

🎉 New feature

Summary

Use the model editor to insert joints into a model.

Test it

Load a world, select a model in the entity tree and try adding a new joint from the "plus" menu.

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[codecov]

Codecov Report

Merging #1196 (e2aea92) into model_editor (65cc189) will decrease coverage by 0.12%.
The diff coverage is 11.53%.

@@               Coverage Diff                @@
##           model_editor    #1196      +/-   ##
================================================
- Coverage         60.12%   59.99%   -0.13%     
================================================
  Files               268      268              
  Lines             21415    21484      +69     
================================================
+ Hits              12876    12890      +14     
- Misses             8539     8594      +55     

Impacted Files	Coverage Δ
include/ignition/gazebo/SdfEntityCreator.hh	100.00% <ø> (ø)
include/ignition/gazebo/gui/GuiEvents.hh	0.00% <0.00%> (ø)
.../plugins/component_inspector/ComponentInspector.hh	28.57% <ø> (ø)
src/gui/plugins/component_inspector/ModelEditor.cc	5.88% <0.00%> (-1.53%)	⬇️
.../plugins/component_inspector/ComponentInspector.cc	6.51% <7.69%> (+0.08%)	⬆️
src/SdfEntityCreator.cc	83.17% <36.36%> (-0.67%)	⬇️
src/systems/physics/Physics.cc	70.67% <50.00%> (-0.08%)	⬇️
src/SimulationRunner.cc	91.45% <0.00%> (+0.91%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65cc189...e2aea92. Read the comment docs.

[nkoenig]

I see a problem when adding a link then a joint. For example:

1. Load shapes.sdf
2. Add a link to the box.
3. Add a joint to the box.
4. Step simulation. You'll see the following errors:

[Err] [SDFFeatures.cc:384] Could not find link link in model box
[Err] [SDFFeatures.cc:750] The link of the child frame [link] with resolved link name [link] of joint [joint] in model [box] could not be resolved. The joint will not be constructed

[mjcarroll]

I see a problem when adding a link then a joint. For example:

I believe it's a sequencing issue in the entity creator, I was able to reproduce and I'm looking at it.

[nkoenig]

I see a problem when adding a link then a joint. For example:

I believe it's a sequencing issue in the entity creator, I was able to reproduce and I'm looking at it.

Do you need assistance on this?

[mjcarroll]

Do you need assistance on this?

No, should have fix shortly.

[iche033]

when I tried adding more than one joint, I see that the first joint will have a valid name, joint, but subsequent joint names are empty:

[mjcarroll]

when I tried adding more than one joint, I see that the first joint will have a valid name, joint, but subsequent joint names are empty

Investigating

[mjcarroll]

Fixed in #1228