Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ViewAngle work with MinimalScene #1016

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Make ViewAngle work with MinimalScene #1016

merged 1 commit into from
Sep 13, 2021

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Part of gazebosim/gz-gui#137

Summary

Make the ViewAngle plugin work with both GzScene3d (legacy behavior) and MinimalScene.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added the GUI Gazebo's graphical interface (not pure Ignition GUI) label Sep 8, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 8, 2021
@chapulina chapulina mentioned this pull request Sep 8, 2021
Closed
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 8, 2021
@chapulina chapulina merged commit 899034b into main Sep 13, 2021
@chapulina chapulina deleted the chapulina/6/view_angle_minimal branch September 13, 2021 17:50
@chapulina chapulina mentioned this pull request Oct 2, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
beta Targeting beta release of upcoming collection 🏯 fortress Ignition Fortress GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @ahcorde