Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gzerr and friends #82

Closed
gerkey opened this issue Apr 21, 2020 · 1 comment
Closed

Support gzerr and friends #82

gerkey opened this issue Apr 21, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@gerkey
Copy link
Contributor

gerkey commented Apr 21, 2020

In the course of migrating a plugin from Gazebo to Ignition (#80), one of the seemingly unnecessary changes was to replace gzerr with ignerr (same for the warn, log, and dbg versions).

Given that the functionality and signature are seemingly unchanged, it would be nice if gzerr and friends just kept working.

If there's a technical challenge to continuing to allow the old names (@chapulina mentioned that there are use cases where gzerr and ignerr are mixed in the same code), then I'm OK with calling this wontfix, given that the cost to the user is a simple search-replace.

@gerkey gerkey added the enhancement New feature or request label Apr 21, 2020
@chapulina chapulina self-assigned this Apr 27, 2020
@chapulina
Copy link
Contributor

Thanks for bringing this up.

I'm OK with calling this wontfix, given that the cost to the user is a simple search-replace.

We'll go with this for now, and we can revisit if it becomes a common pain point to many migrating users.


One thing we should consider more generally would be some migration script that does various search-and-replace tasks, see #98. As a reference, here's a script which, among many things, migrates the console logging macros from ROS 1 to ROS 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants