Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure physics properties #489

Closed
iche033 opened this issue Dec 15, 2020 · 3 comments · Fixed by #536
Closed

Configure physics properties #489

iche033 opened this issue Dec 15, 2020 · 3 comments · Fixed by #536
Labels
close the gap Features from Gazebo-classic enhancement New feature or request GUI Gazebo's graphical interface (not pure Ignition GUI) physics Involves Ignition Physics

Comments

@iche033
Copy link
Contributor

iche033 commented Dec 15, 2020

Support configuring physics properties like max step size, real time update rate, gravity, etc (see Physics SDF DOM and perhaps also some of the fields in physics.proto) through ign gazebo components and/or ign-transport

Additionally a component inspector to let users edit these properties through the gui

@iche033 iche033 added enhancement New feature or request physics Involves Ignition Physics labels Dec 15, 2020
@chapulina chapulina added close the gap Features from Gazebo-classic GUI Gazebo's graphical interface (not pure Ignition GUI) labels Dec 15, 2020
@mrushyendra
Copy link
Contributor

I made some initial changes here to add a component that allows users to change the step size or target rtf. While it works in practice, I was wondering where the best place to actually update the SimulationRunner's stepSize and desiredRtf properties would be. Currently I'm doing it in step here:

https://github.com/mrushyendra/ign-gazebo/blob/56f800e073db107120f924f196fcb92e818b38f6/src/SimulationRunner.cc#L740

but was wondering if that is the right approach. Thank you!

@ahcorde
Copy link
Contributor

ahcorde commented Dec 18, 2020

Hi @mrushyendra

Thank you for picking this issue. I think it would be great if you can create a PR because we can discuss better the code and see easily the new code.

I think you can also consider two more things:

  • It would also be great to make the component inspector call those new topics to edit physics from the GUI.
  • the PhysicCmd should probably be handled by the UserCommands system.

This PR #482 is adding light control, you can get some inspiration.

@luca-della-vedova
Copy link
Member

I started to build on top of the work by @mrushyendra and should be ready to open a draft PR for component inspector control of physics parameters soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
close the gap Features from Gazebo-classic enhancement New feature or request GUI Gazebo's graphical interface (not pure Ignition GUI) physics Involves Ignition Physics
Projects
None yet
5 participants