Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ogre2: retain CMAKE_INSTALL_RPATH values" #910

Closed

Conversation

mjcarroll
Copy link
Contributor

Reverts #909

@mjcarroll mjcarroll requested a review from iche033 as a code owner September 15, 2023 16:04
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #910 (8082c90) into gz-rendering8 (8c1fd27) will not change coverage.
The diff coverage is n/a.

❗ Current head 8082c90 differs from pull request most recent head 21ab227. Consider uploading reports for the commit 21ab227 to get more accurate results

@@              Coverage Diff               @@
##           gz-rendering8     #910   +/-   ##
==============================================
  Coverage          75.18%   75.18%           
==============================================
  Files                177      177           
  Lines              16846    16846           
==============================================
  Hits               12665    12665           
  Misses              4181     4181           

@scpeters
Copy link
Member

CI is still failing; I think #909 was not the cause of the macOS build failure; I'll review the previous failed builds to track it down

@iche033
Copy link
Contributor

iche033 commented Sep 15, 2023

we can close this one?

@scpeters
Copy link
Member

yes, the CI issues were fixed by #911

@scpeters scpeters closed this Sep 18, 2023
@scpeters scpeters deleted the revert-909-scpeters/ogre2_append_rpath branch September 18, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants