Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wide angle camera visibility flags #900

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 6, 2023

🦟 Bug fix

Summary

The default visibility flags conflicts with ogre's internal reserved flags which causes heightmaps to be not visible in the camera view. This PR fixes the visibility flags in the same way that's done for a regular camera.

See gazebosim/harmonic_demo#7 for screenshot

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 changed the base branch from gz-rendering7 to gz-rendering8 September 6, 2023 02:23
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 6, 2023
@iche033 iche033 added 🎵 harmonic Gazebo Harmonic and removed 🌱 garden Ignition Garden labels Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #900 (f23163b) into gz-rendering8 (41f80fd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f23163b differs from pull request most recent head 40c57ad. Consider uploading reports for the commit 40c57ad to get more accurate results

@@              Coverage Diff               @@
##           gz-rendering8     #900   +/-   ##
==============================================
  Coverage          75.21%   75.21%           
==============================================
  Files                176      176           
  Lines              16838    16839    +1     
==============================================
+ Hits               12664    12665    +1     
  Misses              4174     4174           
Files Changed Coverage Δ
ogre2/src/Ogre2WideAngleCamera.cc 85.24% <100.00%> (+0.02%) ⬆️

@mjcarroll mjcarroll merged commit 3c84ca4 into gz-rendering8 Sep 6, 2023
7 checks passed
@mjcarroll mjcarroll deleted the fix_wide_angle_cam_heightmap branch September 6, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants