Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse OGRE2_RESOURCE_PATH as list of strings #867

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 20, 2023

🦟 Bug fix

Fixes gazebosim/gz-cmake#361

Summary

There is a possibility that the OGRE2_RESOURCE_PATH cmake variable can contain multiple paths (strings). This PR updates CMake and source code to parses the variable as a list instead of a string.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #867 (142bc0c) into gz-rendering7 (9f32fcc) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 142bc0c differs from pull request most recent head b0c6262. Consider uploading reports for the commit b0c6262 to get more accurate results

@@                Coverage Diff                @@
##           gz-rendering7     #867      +/-   ##
=================================================
- Coverage          77.15%   77.14%   -0.01%     
=================================================
  Files                170      170              
  Lines              14720    14724       +4     
=================================================
+ Hits               11357    11359       +2     
- Misses              3363     3365       +2     
Impacted Files Coverage Δ
ogre2/src/Ogre2RenderEngine.cc 75.83% <50.00%> (-0.21%) ⬇️

@iche033 iche033 merged commit 4a1d9af into gz-rendering7 Jul 21, 2023
@iche033 iche033 deleted the ogre2_resource_paths branch July 21, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

In gz-cmake 3.2.2 FindGzOgre2 now can define OGRE2_RESOURCE_PATH as a list
3 participants