Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed warning #861

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Removed warning #861

merged 3 commits into from
Jun 9, 2023

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 9, 2023

🦟 Bug fix

Summary

Removed warning: unused parameter

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Jun 9, 2023
@ahcorde ahcorde requested a review from iche033 as a code owner June 9, 2023 15:06
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #861 (d789427) into gz-rendering7 (b32cbd3) will not change coverage.
The diff coverage is n/a.

❗ Current head d789427 differs from pull request most recent head 3826e05. Consider uploading reports for the commit 3826e05 to get more accurate results

@@              Coverage Diff               @@
##           gz-rendering7     #861   +/-   ##
==============================================
  Coverage          77.14%   77.14%           
==============================================
  Files                170      170           
  Lines              14715    14715           
==============================================
  Hits               11352    11352           
  Misses              3363     3363           
Impacted Files Coverage Δ
ogre2/src/Ogre2GzHlmsSharedPrivate.cc 100.00% <ø> (ø)

@ahcorde ahcorde enabled auto-merge (squash) June 9, 2023 15:53
@ahcorde
Copy link
Contributor Author

ahcorde commented Jun 9, 2023

@osrf-jenkins run tests please!

@ahcorde ahcorde merged commit f192e4f into gz-rendering7 Jun 9, 2023
@ahcorde ahcorde deleted the ahcorde/remove/warning branch June 9, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants