Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky VisualAt test on mac #767

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Nov 28, 2022

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

Disable Scene.VisualAt test as it's flaky on macOS, see #758 (comment)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 28, 2022
@iche033 iche033 changed the title disable visual at test on mac Disable flaky VisualAt test on mac Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #767 (222843a) into gz-rendering7 (59dc8e4) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           gz-rendering7     #767   +/-   ##
==============================================
  Coverage          75.48%   75.48%           
==============================================
  Files                164      164           
  Lines              14363    14363           
==============================================
  Hits               10842    10842           
  Misses              3521     3521           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde merged commit 04b0f03 into gz-rendering7 Nov 29, 2022
@ahcorde ahcorde deleted the disable_visualat_test branch November 29, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants