Force scaling factor to be 1.0

[Blast545]

Signed-off-by: Jorge Perez [email protected]

🦟 Bug fix

Fixes #170 (on Citadel)

Forces scale factor to be 1.0, partial backport of #446

Checklist

• Signed all commits for DCO
• Added tests -> Fixes tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

[codecov]

Codecov Report

Merging #647 (846c75a) into ign-rendering3 (2091963) will decrease coverage by 26.61%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           ign-rendering3     #647       +/-   ##
===================================================
- Coverage           80.00%   53.38%   -26.62%     
===================================================
  Files                   1      131      +130     
  Lines                  15    12021    +12006     
===================================================
+ Hits                   12     6418     +6406     
- Misses                  3     5603     +5600     

Impacted Files	Coverage Δ
src/Utils.cc	100.00% <ø> (ø)
test_config.h
ogre2/src/Ogre2Conversions.cc	82.14% <0.00%> (ø)
ogre2/src/Ogre2Object.cc	100.00% <0.00%> (ø)
ogre2/src/Ogre2RenderPass.cc	80.00% <0.00%> (ø)
include/ignition/rendering/base/BaseCamera.hh	70.27% <0.00%> (ø)
include/ignition/rendering/ViewController.hh	100.00% <0.00%> (ø)
include/ignition/rendering/base/BaseDepthCamera.hh	16.66% <0.00%> (ø)
ogre/src/OgreVisual.cc	14.28% <0.00%> (ø)
ogre2/src/Ogre2RenderTarget.cc	72.46% <0.00%> (ø)
... and 123 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2091963...846c75a. Read the comment docs.

[Blast545]

Win PR job is failing due to expected protobuf warnings.

Codecov job is failing probably because there's a section of the code which is now skipped. Should we just remove that section of the code?

[iche033]

I think this patch was more of an experiment to see if it fixes CI test failure, which it did. But I don't know if it actually fixes gazebosim/gz-sim#147 though. I've never been able to reproduce those mouse picking issues in my setup so can't confirm this is the right fix or not so I left the old code there just in case if they come up again.

[Blast545]

@iche033 Makes sense to me, thanks for the explanation. Can you merge the PR? I'm getting an "enable auto-merge" instead of the merge button. (probably because of the failing checks)

[iche033]

merged :)