Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial: Transform FBX to Collada and change its origin #195

Merged
merged 6 commits into from
Jan 26, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jan 12, 2021

Tutorial to transform a FBX file to Collada and change its origin.

Signed-off-by: ahcorde [email protected]

@ahcorde ahcorde added the boost the docs Documentation deployment, usability and parity with classic label Jan 12, 2021
@ahcorde ahcorde requested a review from iche033 January 12, 2021 07:26
@ahcorde ahcorde self-assigned this Jan 12, 2021
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #195 (a2bf85a) into ign-rendering4 (95949c1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering4     #195   +/-   ##
===============================================
  Coverage           52.59%   52.59%           
===============================================
  Files                 143      143           
  Lines               13341    13341           
===============================================
  Hits                 7017     7017           
  Misses               6324     6324           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95949c1...a2bf85a. Read the comment docs.

@chapulina chapulina added documentation Improvements or additions to documentation and removed boost the docs Documentation deployment, usability and parity with classic labels Jan 12, 2021
tutorials/21_transform_fbx_to_dae.md Outdated Show resolved Hide resolved
tutorials/21_transform_fbx_to_dae.md Outdated Show resolved Hide resolved
Signed-off-by: ahcorde <[email protected]>
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor comments. Otherwise looks good to me.

tutorials/21_transform_fbx_to_dae.md Outdated Show resolved Hide resolved

Now we can edit some of the properties of the object.

## Change the origin of the model
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to confirm that this is an optional step right (and not specific to fbx format)? I think some of our models (usually static background models) have offset on purpose so that when we add the model to the scene, we can just leave the pose at 0 and it'll be at the right location.

If it's an optional step, can we add something like

Sometimes a mesh may have an origin at an offset from the desired location. For example, you may want to move the origin of a robot arm to the base or move the origin of a wheel to its center.

Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde requested a review from iche033 January 20, 2021 14:59
Signed-off-by: Ian Chen <[email protected]>
@iche033
Copy link
Contributor

iche033 commented Jan 20, 2021

fixed gif path in 5a3af31

Do you see the gif animation playing in preview? It's mostly a static image for me. However, I see the gifs in other tutorials working. Not sure if it's because of size issue.

@ahcorde
Copy link
Contributor Author

ahcorde commented Jan 21, 2021

fixed gif path in 5a3af31

Do you see the gif animation playing in preview? It's mostly a static image for me. However, I see the gifs in other tutorials working. Not sure if it's because of size issue.

@iche033, I can see the preview on Github. Or which preview are you refering ?

@iche033
Copy link
Contributor

iche033 commented Jan 22, 2021

@iche033, I can see the preview on Github. Or which preview are you refering ?

I'm doing make doc in build dir and seeing the generated documentation files by going to doxygen/html/index.html

@ahcorde
Copy link
Contributor Author

ahcorde commented Jan 26, 2021

@iche033, can you try again ?

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice the gifs are loading for me now

@ahcorde ahcorde merged commit 27f9977 into ign-rendering4 Jan 26, 2021
@ahcorde ahcorde deleted the ahcorde/tutorial/fbx_to_dae branch January 26, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants