Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some windows warnings #183

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Dec 7, 2020

This PR is related with this other PR gazebosim/gz-sensors#58

There are some Windows warning comming from this package. https://build.osrfoundation.org/job/ign_sensors-pr-win/508/msbuild/new/

Signed-off-by: ahcorde [email protected]

@ahcorde ahcorde added the enhancement New feature or request label Dec 7, 2020
@ahcorde ahcorde self-assigned this Dec 7, 2020
@ahcorde ahcorde requested a review from iche033 as a code owner December 7, 2020 13:20
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Dec 7, 2020
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #183 (2fedcd9) into ign-rendering4 (f8ec772) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering4     #183   +/-   ##
===============================================
  Coverage           52.58%   52.58%           
===============================================
  Files                 143      143           
  Lines               13333    13333           
===============================================
  Hits                 7011     7011           
  Misses               6322     6322           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ec772...2fedcd9. Read the comment docs.

@ahcorde
Copy link
Contributor Author

ahcorde commented Dec 7, 2020

Window failure is unrelated.

@ahcorde ahcorde merged commit 26497e7 into ign-rendering4 Dec 7, 2020
@ahcorde ahcorde deleted the ahcorde/remove/windows/warnings branch December 7, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants