You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead of having pure virtual interfaces in include/ignition/rendering, we can merge the Base* implementations from include/ignition/rendering/base/ in to src.
It's a trade off between cleaner separation of code and improving code maintainability and extensibility:
Main advantages:
reduces the number of files to maintain
easier to add/update/remove features or functions in classes
Templated Base classes also them difficult to add private implementations using the pimpl pattern
The text was updated successfully, but these errors were encountered:
Original report (archived issue) by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).
Instead of having pure virtual interfaces in
include/ignition/rendering
, we can merge the Base* implementations frominclude/ignition/rendering/base/
in tosrc
.It's a trade off between cleaner separation of code and improving code maintainability and extensibility:
Main advantages:
Templated Base classes also them difficult to add private implementations using the pimpl pattern
The text was updated successfully, but these errors were encountered: