-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TPE codecheck errors #62
Conversation
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-physics2 #62 +/- ##
================================================
+ Coverage 81.52% 81.53% +0.01%
================================================
Files 103 103
Lines 3432 3434 +2
================================================
+ Hits 2798 2800 +2
Misses 634 634
Continue to review full report at Codecov.
|
There are still some codecheck errors on Jenkins: https://build.osrfoundation.org/job/ignition_physics-ci-pr_any-ubuntu_auto-amd64/684/cppcheckResult/
|
I see the same code check errors running
Not sure if something that could be fixed in ign-physics or we have to modify ign-cmake. We don't install any headers and the directory layout is different so that msg does not apply. We could just ignore it. |
TIL that |
ah yes the auto-generated headers.. |
Signed-off-by: claireyywang <[email protected]>
I have fixed the warning. Ready for another review @iche033 🙇♀️ |
Add tpe to codecheck and fix errors. Remove white spaces and shorten line length. Closes #58
Uses
sh tools/code_check.sh
to conduct code check on tpe