Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package.xml #608

Merged
merged 6 commits into from
May 3, 2024
Merged

Add package.xml #608

merged 6 commits into from
May 3, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Mar 18, 2024

🎉 New feature

Summary

Add package.xml based on dependencies found in .github/ci/packages.

This is to test out using vendor packages to provide Gazebo packages to ROS users (see gazebo-tooling/release-tools#1117).

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested review from mxgrey and scpeters as code owners March 18, 2024 22:05
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.32%. Comparing base (92e02c3) to head (b800913).
Report is 13 commits behind head on gz-physics7.

❗ Current head b800913 differs from pull request most recent head df390df. Consider uploading reports for the commit df390df to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           gz-physics7     #608   +/-   ##
============================================
  Coverage        78.32%   78.32%           
============================================
  Files              140      140           
  Lines             8069     8069           
============================================
  Hits              6320     6320           
  Misses            1749     1749           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.xml Outdated Show resolved Hide resolved
package.xml Outdated

<depend>benchmark</depend>
<depend>bullet</depend>
<depend>dartsim</depend>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know dartsim uses this name in its package.xml file, but I had added a colcon.pkg file to change its package name for colcon's purposes to DART so that colcon-cmake would recognize find_package(DART) (see dartsim/dart#1389)

I haven't yet tried to build a workspace with gz-physics, dartsim, bullet and ODE, and we don't need to block on this, but I'm not sure building all those from source in the same workspace will work properly in this current form

Copy link
Contributor Author

@azeey azeey May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I used colcon graph and saw that gz-physics didn't have a dependency on DART, so I've changed it in df390df

Before

DART            +
gz-cmake3        +********* *****
gz-tools2         +  * ***..*****
gz-utils2          +***.******.*.
gz-math7            + ***********
gz-plugin2           +    ** *.**
gz-common5            +  *** ****
gz-msgs10              + *  *****
sdformat14              + *   ***
gz-fuel_tools9           +     *.
gz-physics7               +    **
gz-rendering8              + ****
gz-transport13              +****
gz-gui8                      + **
gz-sensors8                   +**
gz-sim8                        +*
gz-launch7                      +

After

DART            +         *    ..
gz-cmake3        +********* *****
gz-tools2         +  * ***..*****
gz-utils2          +***.******.*.
gz-math7            + ***********
gz-plugin2           +    ** *.**
gz-common5            +  *** ****
gz-msgs10              + *  *****
sdformat14              + *   ***
gz-fuel_tools9           +     *.
gz-physics7               +    **
gz-rendering8              + ****
gz-transport13              +****
gz-gui8                      + **
gz-sensors8                   +**
gz-sim8                        +*
gz-launch7                      +

@azeey azeey force-pushed the azeey/package_xml branch from 6fda9a7 to df390df Compare May 3, 2024 18:27
@scpeters scpeters merged commit ca40aee into gz-physics7 May 3, 2024
9 checks passed
@scpeters scpeters deleted the azeey/package_xml branch May 3, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants