Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Citadel] [TPE] Add collision detector #60

Merged
merged 8 commits into from
Jun 4, 2020
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 29, 2020

depends on pull request #59

Add collision detector in TPE that checks collisions between pairs of models by doing axis aligned bounding box intersection tests.

If intersection occurs, the collision detector can either return

  • 8 contact points associated with the corners of the intersecting region, or
  • 1 contact point at the center of intersecting region

This can be specified by setting the _singleContact bool variable when calling CollisionDetector::CheckCollisions function

@iche033 iche033 requested a review from mxgrey as a code owner May 29, 2020 00:51
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #60 into ign-physics2 will increase coverage by 0.28%.
The diff coverage is 97.01%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-physics2      #60      +/-   ##
================================================
+ Coverage         81.81%   82.10%   +0.28%     
================================================
  Files               104      106       +2     
  Lines              3492     3559      +67     
================================================
+ Hits               2857     2922      +65     
- Misses              635      637       +2     
Impacted Files Coverage Δ
tpe/lib/src/World.hh 100.00% <ø> (ø)
tpe/lib/src/World.cc 90.62% <33.33%> (-5.93%) ⬇️
tpe/lib/src/CollisionDetector.cc 100.00% <100.00%> (ø)
tpe/lib/src/CollisionDetector.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6511872...7efa98d. Read the comment docs.

Signed-off-by: Ian Chen <[email protected]>
Base automatically changed from entity_bbox to ign-physics2 June 3, 2020 01:56
iche033 added 2 commits June 2, 2020 20:20
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Copy link
Contributor

@claireyywang claireyywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we can just suppress the dll warnings from windows CI. I did the same with tpelib.

Signed-off-by: Ian Chen <[email protected]>
@iche033
Copy link
Contributor Author

iche033 commented Jun 4, 2020

suppressed dll warnings in b5e4700. Waiting for one more round of CI

Signed-off-by: Ian Chen <[email protected]>
@iche033
Copy link
Contributor Author

iche033 commented Jun 4, 2020

all checks passed, merging

@iche033 iche033 merged commit 12e7299 into ign-physics2 Jun 4, 2020
@iche033 iche033 deleted the collision_detector branch June 4, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants