-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Citadel] [TPE] Add collision detector #60
Conversation
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-physics2 #60 +/- ##
================================================
+ Coverage 81.81% 82.10% +0.28%
================================================
Files 104 106 +2
Lines 3492 3559 +67
================================================
+ Hits 2857 2922 +65
- Misses 635 637 +2
Continue to review full report at Codecov.
|
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think we can just suppress the dll warnings from windows CI. I did the same with tpelib.
Signed-off-by: Ian Chen <[email protected]>
suppressed dll warnings in b5e4700. Waiting for one more round of CI |
Signed-off-by: Ian Chen <[email protected]>
all checks passed, merging |
depends on pull request #59
Add collision detector in TPE that checks collisions between pairs of models by doing axis aligned bounding box intersection tests.
If intersection occurs, the collision detector can either return
This can be specified by setting the
_singleContact
bool variable when callingCollisionDetector::CheckCollisions
function