dartsim: Fix sign convention error with contact surface motion velocities #556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes gazebosim/gz-sim#2008
Needed by gazebosim/gz-sim#2178
Summary
The implementation of contact constraints in the upstream version of dart uses a different sign due to the order of operands in a cross product. See dart 6.10 fork vs dart 6.13 upstream. This PR inverts the sign for velocities in the first and second friction directions if it detects that the upstream version of DART is being used. See also gazebo-forks/dart#33
This also enables a test that was accidentally disabled when we transitioned to common tests. The
DART_HAS_CONTACT_SURFACE
define is necessary to run the surface velocity tests.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.