Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate packages.apt files #528

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Aug 7, 2023

🦟 Bug fix

Small follow-up to #526

Summary

The packages-focal.apt file was removed in #526, so packages-jammy.apt can now be consolidated with packages.apt, which is done here.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Move contents of packages-jammy.apt to packages.apt
since packages-focal.apt has been removed.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested review from azeey and mxgrey as code owners August 7, 2023 19:53
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #528 (d54c106) into main (605041e) will not change coverage.
The diff coverage is n/a.

❗ Current head d54c106 differs from pull request most recent head 9cbc637. Consider uploading reports for the commit 9cbc637 to get more accurate results

@@           Coverage Diff           @@
##             main     #528   +/-   ##
=======================================
  Coverage   77.15%   77.15%           
=======================================
  Files         139      139           
  Lines        7603     7603           
=======================================
  Hits         5866     5866           
  Misses       1737     1737           

@azeey
Copy link
Contributor

azeey commented Aug 7, 2023

@j-rivero Looks like we still have ignition_physics-ci-pr_any-ubuntu_auto-amd64 in addition to gz_physics-ci-pr_any-jammy-amd64

@scpeters
Copy link
Member Author

scpeters commented Aug 7, 2023

also we should remove Ubuntu Focal CI from the list of required CI jobs for the main branch

@azeey azeey added the beta Targeting beta release of upcoming collection label Aug 7, 2023
@scpeters
Copy link
Member Author

scpeters commented Aug 7, 2023

also we should remove Ubuntu Focal CI from the list of required CI jobs for the main branch

I removed Ubuntu Focal CI from the list of required CI checks for the main branch, but there is a bit more configuration needed before the harmonic release

@scpeters
Copy link
Member Author

@j-rivero Looks like we still have ignition_physics-ci-pr_any-ubuntu_auto-amd64 in addition to gz_physics-ci-pr_any-jammy-amd64

for now I will replace ignition_physics-ci-pr_any-ubuntu_auto-amd64 with gz_physics-ci-pr_any-jammy-amd64 in the list of required builds for the main branch

@scpeters scpeters merged commit 1a27018 into main Aug 17, 2023
@scpeters scpeters deleted the scpeters/consolidate_packages_apt branch August 17, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants