Fix bullet related segfaults on macOS #504
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #497
Summary
This fixes two tests with segfaults on macOS
COMMON_TEST_simulation_features_bullet-featherstone
: The failure appears to be due to the destruction order of thetriangleMeshes
andmeshesGImpact
containers. Per [this] (Should btBroadphaseInterface destructor remove itself from btCollisionObject broadphase proxies? bulletphysics/bullet3#567 (comment)) comment, memory in bullet is sensitive to order of destruction.meshesGImpact
objects contain pointers to items contained bytriangleMeshes
, so the solution is to ensuremeshesGImpact
is destructed beforetriangleMeshes
.INTEGRATION_DoublePendulum
: This is a DART test, but the segfault seems to be related to Bullet. I found that even after removing all the code inDARTDoublePendulum.cc
, the segfault still occurs as long as it's linked withlibdart-collision-bullet
. Since the test doesn't need the bullet collision detector, I've opted to just remove the library from theDART_LIBRARIES
variable. I still don't know the root cause though, so this might affect the actual dartsim-plugin library.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.