Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dartsim: Refactor entity addition logic in the EntityStorage class #500

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Mar 30, 2023

🎉 New feature

Summary

The entity addition logic is for each type of entity. This refactors it to an AddEntity member function. This will be used in a follow up PR for supporting world joints.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from marcoag March 30, 2023 21:59
@azeey azeey requested review from mxgrey and scpeters as code owners March 30, 2023 21:59
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Mar 30, 2023
@azeey azeey self-assigned this Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #500 (dc05a93) into gz-physics6 (8736107) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head dc05a93 differs from pull request most recent head 9044f21. Consider uploading reports for the commit 9044f21 to get more accurate results

@@               Coverage Diff               @@
##           gz-physics6     #500      +/-   ##
===============================================
- Coverage        75.56%   75.50%   -0.07%     
===============================================
  Files              142      142              
  Lines             7191     7173      -18     
===============================================
- Hits              5434     5416      -18     
  Misses            1757     1757              
Impacted Files Coverage Δ
dartsim/src/Base.hh 95.00% <100.00%> (-0.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@azeey
Copy link
Contributor Author

azeey commented Mar 31, 2023

@osrf-jenkins run tests please

@azeey
Copy link
Contributor Author

azeey commented Mar 31, 2023

The failing tests are also failing on the stable branch CI, so I'll go ahead and merge.

@azeey azeey merged commit 12baaf7 into gazebosim:gz-physics6 Mar 31, 2023
@azeey azeey deleted the refactor_dartsim_base branch March 31, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants