Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add main function to joint transmitted wrench test #496

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes test coverage reduced in #495

Summary

I quickly approved and merged #495 that moved a test to a new file without realizing that it was missing the custom main function that is required for our common tests that allows passing the plugin library to the test from the CLI. There was reduced test coverage in #495 and I didn't realize why. This should fix it.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Fix the test added in #495.

Signed-off-by: Steve Peters <[email protected]>
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #496 (b2ed03d) into gz-physics6 (adde787) will increase coverage by 0.54%.
The diff coverage is n/a.

❗ Current head b2ed03d differs from pull request most recent head 66bc383. Consider uploading reports for the commit 66bc383 to get more accurate results

@@               Coverage Diff               @@
##           gz-physics6     #496      +/-   ##
===============================================
+ Coverage        75.02%   75.56%   +0.54%     
===============================================
  Files              142      142              
  Lines             7191     7191              
===============================================
+ Hits              5395     5434      +39     
+ Misses            1796     1757      -39     

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters scpeters merged commit ee36344 into gz-physics6 Mar 23, 2023
@scpeters scpeters deleted the scpeters/fix_test branch March 23, 2023 18:06
@scpeters scpeters mentioned this pull request Mar 28, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants