Fix windows warnings related to bullet #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-physics5 #473 +/- ##
================================================
+ Coverage 76.34% 76.35% +0.01%
================================================
Files 129 129
Lines 5808 5811 +3
================================================
+ Hits 4434 4437 +3
Misses 1374 1374
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ahcorde
approved these changes
Jan 19, 2023
ahcorde
reviewed
Jan 19, 2023
bullet/src/plugin.cc
Outdated
|
|
||
| return this->GenerateIdentity(0); | ||
| } | ||
|
|
mjcarroll
approved these changes
Jan 19, 2023
Signed-off-by: Addisu Z. Taddese <[email protected]>
azeey
force-pushed
the
fix_win_warnings
branch
from
8f2f0a2 to
2f7111a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.