Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce error to debug and add notes #452

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Reduce error to debug and add notes #452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions dartsim/src/SDFFeatures.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,11 @@ static ShapeAndTransform ConstructPlane(
static ShapeAndTransform ConstructHeightmap(
const ::sdf::Heightmap & /*_heightmap*/)
{
gzerr << "Heightmap construction from an SDF has not been implemented yet "
<< "for dartsim.\n";
// TODO(mjcarroll) Allow dartsim to construct heightmaps internally rather
// than relying on the physics consumer constructing and attaching:
// https://github.com/gazebosim/gz-physics/issues/451
gzdbg << "Heightmap construction from an SDF has not been implemented yet "
<< "for dartsim. Use AttachHeightmapShapeFeature to use heightmaps.\n";
return {nullptr};
}

Expand All @@ -317,8 +320,11 @@ static ShapeAndTransform ConstructMesh(
{
// TODO(MXG): Look into what kind of mesh URI we get here. Will it just be
// a local file name, or do we need to resolve the URI?
gzerr << "Mesh construction from an SDF has not been implemented yet for "
<< "dartsim.\n";
// TODO(mjcarroll) Allow dartsim to construct meshes internally rather
// than relying on the physics consumer constructing and attaching:
// https://github.com/gazebosim/gz-physics/issues/451
gzdbg << "Mesh construction from an SDF has not been implemented yet for "
<< "dartsim. Use AttachMeshShapeFeature to use mesh shapes.\n";
return {nullptr};
}

Expand Down