Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce error to debug and add notes #452

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

mjcarroll
Copy link
Contributor

Partially addresses #450 by reducing the verbosity of the two errors from "error" to "debug".

In reality, these aren't really errors per se, as the dartsim plugin continues to process the SDF and then attaches meshes and heightmaps in a later stage.

The recent addition of gazebosim/gz-sim#1560 allowing SDF to be constructed in a single shot uncovered these unimplemented functions.

The more complete fix is to take advantage of constructing the models in place, which I have opening an issue for at #451.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 28, 2022
@mjcarroll mjcarroll force-pushed the mjcarroll/downgrade_error branch from a98d215 to 077d46b Compare November 28, 2022 18:36
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #452 (f4111cb) into gz-physics6 (bab13ef) will not change coverage.
The diff coverage is 0.00%.

❗ Current head f4111cb differs from pull request most recent head 077d46b. Consider uploading reports for the commit 077d46b to get more accurate results

@@             Coverage Diff              @@
##           gz-physics6     #452   +/-   ##
============================================
  Coverage        75.79%   75.79%           
============================================
  Files              140      140           
  Lines             7056     7056           
============================================
  Hits              5348     5348           
  Misses            1708     1708           
Impacted Files Coverage Δ
dartsim/src/SDFFeatures.cc 64.07% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit 86d5a0f into gz-physics6 Nov 28, 2022
@mjcarroll mjcarroll deleted the mjcarroll/downgrade_error branch November 28, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants