Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport windows fix #437

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Backport windows fix #437

merged 1 commit into from
Oct 10, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Oct 8, 2022

🦟 Bug fix

Backport #436.

Summary

Fixes windows build by not unconditionally adding symbolic links.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Backport #436.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from nkoenig October 8, 2022 00:09
@scpeters scpeters requested review from azeey and mxgrey as code owners October 8, 2022 00:09
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Oct 8, 2022
@scpeters scpeters mentioned this pull request Oct 8, 2022
8 tasks
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #437 (705e8aa) into ign-physics5 (4ef1d65) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           ign-physics5     #437   +/-   ##
=============================================
  Coverage         76.34%   76.34%           
=============================================
  Files               129      129           
  Lines              5808     5808           
=============================================
  Hits               4434     4434           
  Misses             1374     1374           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde merged commit 3b7995a into ign-physics5 Oct 10, 2022
@ahcorde ahcorde deleted the scpeters/backport_windows_fix branch October 10, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants