Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to installation documentation #416

Merged

Conversation

JoanAguilar
Copy link
Contributor

Signed-off-by: Joan Aguilar Mayans [email protected]

🦟 Bug fix

Part of Garden tutorial party, issue gazebosim/garden-tutorial-party#295. Updates to source installation instructions for Ubuntu (Focal).

Summary

  • Added instructions to install packages gnupg, wget, and cppcheck.
  • Updated references to packages/branches.

Note that since this is pointing to a pre-release, I had to use ubuntu-nightly rather than ubuntu-stable for the instructions to work. I'm assuming that this will resolve itself once the prerelease becomes a proper release.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #416 (e7798ed) into gz-physics6 (e026533) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           gz-physics6     #416   +/-   ##
============================================
  Coverage        73.85%   73.85%           
============================================
  Files              128      128           
  Lines             5775     5775           
============================================
  Hits              4265     4265           
  Misses            1510     1510           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

```
Be sure to replace `<#>` with a number value, such as `1` or `2`, depending on which version you need.
Be sure to replace `<#>` with a number value, such as `5` or `6`, depending on which version you need.
Older versions can be installed by using the `libignition-physics<#>-dev` packages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we specify which are the older versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

88b8ada

Signed-off-by: Joan Aguilar Mayans <[email protected]>
@JoanAguilar JoanAguilar requested a review from ahcorde September 7, 2022 21:52
```
Be sure to replace `<#>` with a number value, such as `1` or `2`, depending on which version you need.
Be sure to replace `<#>` with a number value, such as `5` or `6`, depending on which version you need.
On Focal, versions `2`, `3`, and `4`, can be installed by using the `libignition-physics<#>-dev` packages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say something like from version 6, you should use libgz-physics<#>-dev, for lower version libignition-physics<#>-dev

Signed-off-by: Joan Aguilar Mayans <[email protected]>
@JoanAguilar JoanAguilar requested a review from ahcorde September 7, 2022 22:08
@JoanAguilar JoanAguilar merged commit 7aa85e0 into gz-physics6 Sep 7, 2022
@JoanAguilar JoanAguilar deleted the joanaguilar/garden-tutorial/installation-focal-source branch September 7, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants