Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bullet classic entity management #393

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Conversation

mxgrey
Copy link
Contributor

@mxgrey mxgrey commented Jul 25, 2022

This PR fixes the entity management features for the bullet classic plugin. It also fixes the seg fault that was reported in this other PR for gz-sim.

@mxgrey mxgrey requested review from azeey and scpeters as code owners July 25, 2022 13:56
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 25, 2022
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #393 (91ec7ef) into main (f226dc7) will decrease coverage by 0.21%.
The diff coverage is 14.28%.

❗ Current head 91ec7ef differs from pull request most recent head db25242. Consider uploading reports for the commit db25242 to get more accurate results

@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
- Coverage   76.77%   76.56%   -0.22%     
==========================================
  Files         128      128              
  Lines        5628     5657      +29     
==========================================
+ Hits         4321     4331      +10     
- Misses       1307     1326      +19     
Impacted Files Coverage Δ
bullet/src/EntityManagementFeatures.cc 9.39% <0.72%> (-3.20%) ⬇️
bullet/src/Base.hh 74.57% <95.45%> (+26.04%) ⬆️
bullet/src/SDFFeatures.cc 45.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f226dc7...db25242. Read the comment docs.

@mjcarroll mjcarroll merged commit 296c5f1 into main Jul 26, 2022
@mjcarroll mjcarroll deleted the fix-bullet-classic-entities branch July 26, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bullet Bullet engine 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants