Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gravity feature to bullet-featherstone #375

Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 8, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

Added gravity to bullet-featherstone. Also fixed a bug when loading the world related to sdf bullet tags

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde requested a review from mjcarroll July 8, 2022 15:44
@ahcorde ahcorde requested a review from azeey as a code owner July 8, 2022 15:44
@ahcorde ahcorde self-assigned this Jul 8, 2022
@ahcorde ahcorde requested review from mxgrey and scpeters as code owners July 8, 2022 15:44
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #375 (3de9702) into ahcorde/suggestions/373 (4202ab6) will increase coverage by 4.47%.
The diff coverage is 96.15%.

@@                     Coverage Diff                     @@
##           ahcorde/suggestions/373     #375      +/-   ##
===========================================================
+ Coverage                    68.27%   72.75%   +4.47%     
===========================================================
  Files                          137      138       +1     
  Lines                         6365     6380      +15     
===========================================================
+ Hits                          4346     4642     +296     
+ Misses                        2019     1738     -281     
Impacted Files Coverage Δ
bullet-featherstone/src/plugin.cc 100.00% <ø> (ø)
bullet-featherstone/src/WorldFeatures.cc 92.30% <92.30%> (ø)
bullet-featherstone/src/SDFFeatures.cc 68.14% <100.00%> (+68.14%) ⬆️
bullet-featherstone/src/Base.hh 80.51% <0.00%> (+68.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4202ab6...3de9702. Read the comment docs.

@chapulina chapulina added the 🌱 garden Ignition Garden label Jul 8, 2022
@ahcorde ahcorde merged commit b68a0d7 into ahcorde/suggestions/373 Jul 12, 2022
@ahcorde ahcorde deleted the ahcorde/add-bullet-featherstone/gravity branch July 12, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants