Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Macro Migration : gz-physics #353

Merged
merged 4 commits into from
Jun 18, 2022
Merged

ign -> gz Macro Migration : gz-physics #353

merged 4 commits into from
Jun 18, 2022

Conversation

methylDragon
Copy link
Contributor

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 6, 2022
@methylDragon methylDragon mentioned this pull request Jun 6, 2022
Closed
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 7, 2022
@chapulina chapulina self-requested a review June 7, 2022 00:00
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jun 7, 2022
chapulina
chapulina reviewed Jun 7, 2022
View reviewed changes
include/ignition/physics/OperateOnSpecifiedData.hh Outdated Show resolved Hide resolved
Migration.md Outdated Show resolved Hide resolved
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@codecov
Copy link

codecov bot commented Jun 18, 2022 •
edited
Loading

Codecov Report

Merging #353 (c549447) into main (a7f3935) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   75.46%   75.46%           
=======================================
  Files         128      128           
  Lines        5552     5552           
=======================================
  Hits         4190     4190           
  Misses       1362     1362
Impacted Files Coverage Δ
dartsim/src/SimulationFeatures.cc 90.16% <ø> (ø)
include/gz/physics/CompositeData.hh 100.00% <ø> (ø)
include/gz/physics/FrameID.hh 100.00% <ø> (ø)
include/gz/physics/Geometry.hh 100.00% <ø> (ø)
include/gz/physics/detail/CompositeData.hh 100.00% <ø> (ø)
include/gz/physics/detail/FeatureList.hh 100.00% <ø> (ø)
include/gz/physics/detail/Identity.hh 100.00% <ø> (ø)
include/gz/physics/detail/PrivateSpecifyData.hh 100.00% <ø> (ø)
include/gz/physics/detail/Register.hh 100.00% <ø> (ø)
include/gz/physics/detail/RelativeQuantity.hh 91.95% <ø> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f3935...c549447. Read the comment docs.

@methylDragon methylDragon merged commit ab627be into main Jun 18, 2022
@methylDragon methylDragon deleted the macro_migration branch June 18, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@mxgrey mxgrey Awaiting requested review from mxgrey

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina