Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SuppressWarning from ign-utils #343

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Looks like a left-over from

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Apr 13, 2022
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #343 (5a442a0) into ign-physics5 (0111a8f) will increase coverage by 21.37%.
The diff coverage is n/a.

❗ Current head 5a442a0 differs from pull request most recent head a9a8ebb. Consider uploading reports for the commit a9a8ebb to get more accurate results

@@                Coverage Diff                @@
##           ign-physics5     #343       +/-   ##
=================================================
+ Coverage         76.08%   97.46%   +21.37%     
=================================================
  Files               129       70       -59     
  Lines              5729     1381     -4348     
=================================================
- Hits               4359     1346     -3013     
+ Misses             1370       35     -1335     
Impacted Files Coverage Δ
tpe/lib/src/Link.hh
sdf/include/ignition/physics/sdf/ConstructLink.hh
tpe/plugin/src/ShapeFeatures.cc
tpe/lib/src/Collision.cc
include/ignition/physics/detail/CanReadData.hh
tpe/plugin/src/FreeGroupFeatures.cc
tpe/plugin/src/SDFFeatures.cc
bullet/src/KinematicsFeatures.cc
...clude/ignition/physics/heightmap/HeightmapShape.hh
include/ignition/physics/detail/GetBoundingBox.hh
... and 189 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0111a8f...a9a8ebb. Read the comment docs.

@chapulina chapulina merged commit 8e81829 into ign-physics5 Apr 13, 2022
@chapulina chapulina deleted the chapulina/5/suppress branch April 13, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants