Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ignition-physics CMake config files relocatable #282

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Aug 3, 2021

🦟 Bug fix

Summary

Avoid to use EIGEN3_INCLUDE_DIRS variable with target_include_directories command, as this result in hardcoding the EIGEN3_INCLUDE_DIRS value in the ignition-physics build machine, that could be different from the location where the Eigen3 include directories are installed in the machine that is consuming the ignition-physics CMake package.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #282 (09b0d0a) into ign-physics4 (34dbb87) will not change coverage.
The diff coverage is n/a.

❗ Current head 09b0d0a differs from pull request most recent head c98a8dd. Consider uploading reports for the commit c98a8dd to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           ign-physics4     #282   +/-   ##
=============================================
  Coverage         75.75%   75.75%           
=============================================
  Files               125      125           
  Lines              5503     5503           
=============================================
  Hits               4169     4169           
  Misses             1334     1334           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34dbb87...c98a8dd. Read the comment docs.

@traversaro
Copy link
Contributor Author

(I will fix DCO tommorow morning in CEST time zone)

@scpeters scpeters merged commit f38120b into gazebosim:ign-physics4 Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants