Make ignition-physics CMake config files relocatable #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Avoid to use
EIGEN3_INCLUDE_DIRS
variable withtarget_include_directories
command, as this result in hardcoding theEIGEN3_INCLUDE_DIRS
value in the ignition-physics build machine, that could be different from the location where the Eigen3 include directories are installed in the machine that is consuming the ignition-physics CMake package.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge