Remove use of deprecated function sdf::JointAxis::InitialPosition #276
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
chapulina
added
the
needs upstream release
| @@ -1115,30 +1101,6 @@ Identity SDFFeatures::ConstructSdfJoint( | |||
| joint->setTransformFromParentBodyNode(parent_T_prejoint_init); | |||
| joint->setTransformFromChildBodyNode(child_T_postjoint); | |||
There was a problem hiding this comment.
Is this block up here still needed? The comment seems outdated
There was a problem hiding this comment.
agreed, the comment seems outdated
There was a problem hiding this comment.
I'm going to merge this now to unbreak things but will open an issue to follow up on this comment
There was a problem hiding this comment.
Yes, the code is needed, but the comment is indeed outdated. I think it can simply be removed.
|
I am trying to build Fortress and hit this issue. InitialPosition has been removed so ign-physics doesn't build out of the box. |
|
the ign-physics nightly build is broken until we get this in |
chapulina
removed
the
needs upstream release
|
My bad for merging gazebosim/sdformat#622 before merging this. |
no worries, it was easy to fix |
Summary
gazebosim/sdformat#622 will remove
sdf::JointAxis::InitialPosition, so we need to stop using it here.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge