Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump in edifice: ign-common4 #205

Merged
merged 2 commits into from
Feb 21, 2021
Merged

Bump in edifice: ign-common4 #205

merged 2 commits into from
Feb 21, 2021

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from mjcarroll January 22, 2021 22:35
@chapulina chapulina requested a review from mxgrey as a code owner January 22, 2021 22:35
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Jan 22, 2021
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #205 (ba00ff1) into main (765e6c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   82.86%   82.86%           
=======================================
  Files         106      106           
  Lines        4115     4115           
=======================================
  Hits         3410     3410           
  Misses        705      705           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 765e6c7...ba00ff1. Read the comment docs.

@scpeters
Copy link
Member

the Ubuntu jenkins build is installing both common3 and common4 and failing (I believe since gazebosim/gz-common#170 is not yet merged)

perhaps it's due to this line in release-tools?

@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Feb 19, 2021
@chapulina chapulina merged commit b0a8c95 into main Feb 21, 2021
@chapulina chapulina deleted the bump_edifice_ign-common branch February 21, 2021 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice needs upstream release Blocked by a release of an upstream library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants