Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support standalone executable in gz-msgs11 #357

Merged
merged 10 commits into from
Jan 3, 2024

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Jun 27, 2023

🎉 New feature

Reworks #353 for ionic

Summary

This adds support for a standalone gz-utils::cli based executable for message introspection.

It additionally modifies the ruby scripts so that gz-tools will continue to work.

This also removes the compiled component introduced in #339, as it's not really necessary with the new standalone executable structure.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll mjcarroll requested a review from caguero as a code owner June 27, 2023 16:46
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (171e1bd) 97.26% compared to head (8e80699) 97.41%.

Files Patch % Lines
core/cmd/msgs_main.cc 98.07% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   97.26%   97.41%   +0.15%     
==========================================
  Files          27       27              
  Lines        1170     1201      +31     
==========================================
+ Hits         1138     1170      +32     
+ Misses         32       31       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

core/cmd/msgs_main.cc Show resolved Hide resolved
core/cmd/msgs_main.cc Show resolved Hide resolved
@mjcarroll mjcarroll force-pushed the mjcarroll/standalone_executable branch from 9c31062 to ae36d54 Compare June 28, 2023 19:20
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
@azeey azeey removed the beta Targeting beta release of upcoming collection label Aug 25, 2023
@mjcarroll mjcarroll self-assigned this Oct 4, 2023
@mjcarroll mjcarroll force-pushed the mjcarroll/standalone_executable branch from ae36d54 to 2b0ba69 Compare December 11, 2023 17:34
@azeey
Copy link
Contributor

azeey commented Dec 12, 2023

The description says "Reworks #353 for harmonic", but the PR is targeting main. Is that right?

@mjcarroll
Copy link
Contributor Author

The description says "Reworks #353 for harmonic", but the PR is targeting main. Is that right?

It should be for main, so ionic at this point.

Signed-off-by: Michael Carroll <[email protected]>
core/cmd/msgs_main.cc Show resolved Hide resolved
Signed-off-by: Michael Carroll <[email protected]>
@azeey azeey removed the 🎵 harmonic Gazebo Harmonic label Dec 13, 2023
@azeey azeey changed the title Support standalone executable in gz-msgs10 Support standalone executable in gz-msgs11 Dec 13, 2023
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll requested a review from ahcorde January 3, 2024 19:30
@ahcorde ahcorde merged commit c93aab8 into main Jan 3, 2024
10 checks passed
@ahcorde ahcorde deleted the mjcarroll/standalone_executable branch January 3, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants