Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignition/msgs/test_config.h has failing include statement #302

Closed
scpeters opened this issue Sep 13, 2022 · 3 comments
Closed

ignition/msgs/test_config.h has failing include statement #302

scpeters opened this issue Sep 13, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@scpeters
Copy link
Member

Environment

  • OS Version: Ubuntu 20.04
  • Source or binary build? ABI checker CI build

Description

  • Expected behavior: ABI checker build should compile all headers successfully
  • Actual behavior: ABI checker fails to compile a header

The include/ignition/msgs/test_config.h header file was added in #249, but it redirects to a non-existent header file. I'm guessing that this redirection header should not have been added in the first place?

Steps to reproduce

  1. Create a pull request without API/ABI changes targeting gz-msgs9 (such as gz_TEST: one more ign -> gz #301)
  2. Observe failure, and view workspace log

Output

In file included from /tmp/suIk835nXK/dump1.h:17:
/usr/local/destination_branch/include/gz/msgs9/ignition/msgs/test_config.h:18:10: fatal error: gz/msgs/test_config.h: No such file or directory
   18 | #include <gz/msgs/test_config.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
@scpeters scpeters added the bug Something isn't working label Sep 13, 2022
@methylDragon
Copy link
Contributor

In the other libs I'd add a line to

configure_file (test_config.h.in
to also configure a gz version of the test_config file.

Let's do that instead?

@methylDragon
Copy link
Contributor

Correction:
The redirection target was removed as of 7cf04fc , so the current test_config redirection header leads nowhere.

Furthermore, since the prefix was removed in the above commit, there is no need for a redirection header in the first place.

For both of those reasons, let's remove the test_config redirection header.

@scpeters
Copy link
Member Author

ignition/msgs/test_config.h removed in #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants