Prototype: parse version number from package.xml #639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Silvio Traversaro <[email protected]>
Use CMAKE_INSTALL_LIBDIR from GNUInstallDirs instead of GZ_LIB_INSTALL_DIR, which won't be available if only building python bindings. Signed-off-by: Steve Peters <[email protected]>
Refer to https://brew.sh instead of duplicating the brew installation command. Signed-off-by: Steve Peters <[email protected]>
* Describe Pybind11 as a dependency * Document how to build bindings separately from the main gz-math library Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Moves find_package(pybind11) call to src/python_pybind11 folder. When invoked through the root CMakeLists.txt, it treats pybind11 as an optional dependency, but when invoked from that folder, it treats it as required by setting CMAKE_REQUIRE_FIND_PACKAGE_pybind11 to TRUE. Signed-off-by: Steve Peters <[email protected]>
This was referenced Oct 20, 2024
Base automatically changed from
scpeters/build_python_bindings_separately
to
gz-math8
October 28, 2024 20:50
7 tasks
9 tasks
|
superseded by #642 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not for merging: part of #636
This uses a short python script to parse the version number from the package.xml file. It does minimal validation:
<package><version>element using the regex from catkin_pkgIn order to run this script from cmake, we need to find
Python3before theproject()statement. It also splits the version number and uses the major version in the project name.If we like this approach, we can consider adding the script and a helper cmake function/macro to gz-cmake, so that the block of cmake code before the
project()statement could be replaced byfind_package(gz-cmakeX)and then the helper cmake call. Note that we can't wrap theproject()call (from cmake docs):