Tidy up copy, copy-assign, and destructors #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove virtual from destructors of copyable classes. A class that is copyable or copy-assignable should never be virtual, because any subclass will be subject to the slicing problem. Use '= default' anytime we just want the default implementation. Writing out the list of member fields by hand is error-prone. Signed-off-by: Jeremy Nimmer <[email protected]>
ahcorde
approved these changes
Nov 24, 2021
mjcarroll
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Somewhat related to #269 -- a class with a virtual destructor cannot be
constexpr.Summary
Tidy up copy, copy-assign, and destructors
Remove virtual from destructors of copyable classes. A class that is copyable or copy-assignable should never be virtual, because any subclass will be subject to the slicing problem.
Use
= defaultanytime we just want the default implementation. Writing out the list of member fields by hand is error-prone.Checklist
Added tests (N/A)Updated documentation (as needed)Updated migration guide (as needed)codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge